Repository navigation
epd1in54: set the RAM address before each frame write - #945
Merged
Merged
Conversation
After LDirInit the image was one row lower than the buffer, and the top row was drawn on the bottom edge of the panel. LDirInit set the RAM address counter while the display was busy, so the controller ignored it. Set the RAM X and Y address counters before each RAM write.
deadprogram
approved these changes
Nov 13, 2026
deadprogram
left a comment
Member
There was a problem hiding this comment.
Thank you for the fix @davecheney
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After LDirInit the image was one row lower than the buffer, and the top row was drawn on the bottom edge of the panel. LDirInit set the RAM address counter while the display was busy, so the controller ignored it.
Set the RAM X and Y address counters before each RAM write.